Skip to content

Conversation

@wkia
Copy link

@wkia wkia commented Jun 5, 2025

This is backport of "8347826: Introspector shows wrong method list after 8071693"

The backport is almost clean, the only conflicts were in copyright year in 2 files.

The modified test fails without the fix, and passes after the fix is applied.


Progress

  • JDK-8347826 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347826: Introspector shows wrong method list after 8071693 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3618/head:pull/3618
$ git checkout pull/3618

Update a local copy of the PR:
$ git checkout pull/3618
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3618

View PR using the GUI difftool:
$ git pr show -t 3618

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3618.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2025

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@wkia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347826: Introspector shows wrong method list after 8071693

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 264 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport c5f235c000db6654493ea109008dbccf97f01678 8347826: Introspector shows wrong method list after 8071693 Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 5, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2025

Webrevs

@wkia
Copy link
Author

wkia commented Jun 6, 2025

/approval request I'd like to backport this to 17u. The backport is almost clean. PR checks are OK. This backport fixes the wrong method and property list returning by Introspector broken after 8071693 in 17.0.14.

@openjdk
Copy link

openjdk bot commented Jun 6, 2025

@wkia
8347826: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jun 6, 2025
@anuj-ion
Copy link

anuj-ion commented Jun 21, 2025

Hi, this request is about backporting fix to Java 17 (JDK-8347826). Backport request for same fix on Java 21 was completed 2 weeks back (JDK-8358779). If someone can take a look, it would be very helpful.
Many thanks,
Anuj

@anuj-ion
Copy link

anuj-ion commented Jul 4, 2025

@GoeLin , Sir, you validated same request for JDK21 last month. Can you please help to move this PR as well.
Many thanks,
Anuj

@anuj-ion
Copy link

@wkia, PR still pending approval. We are eagerly waiting for it to merge in main branch so that we are able to upgrade to latest stable JDK17.

@wkia
Copy link
Author

wkia commented Jul 15, 2025

@anuj-ion AFAIU the change was deferred to the next release, at least the JDK bug's label seems so.

@anuj-ion
Copy link

@wkia , Ah, I didn't notice the label. Thanks for sharing this info. Will it be a candidate for 17.0.18?

@wkia
Copy link
Author

wkia commented Jul 16, 2025

@anuj-ion yes, I hope so.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2025

@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@wkia
Copy link
Author

wkia commented Aug 13, 2025

/touch

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

@wkia The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 25, 2025
@GoeLin
Copy link
Member

GoeLin commented Aug 25, 2025

I would prefer that changes have some exposure in a higher release before they are brought to 17. But as this fixes a regression let's go.
Please make sure this sitll tests well with current jdk17u-dev.

@wkia
Copy link
Author

wkia commented Aug 26, 2025

Checked: The modified test fails without the fix, and passes after the fix is applied on the latest master.

@wkia
Copy link
Author

wkia commented Aug 26, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 26, 2025
@openjdk
Copy link

openjdk bot commented Aug 26, 2025

@wkia
Your change (at version fbb383e) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 3, 2025

Going to push as commit 7842c7d.
Since your change was applied there have been 266 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 3, 2025
@openjdk openjdk bot closed this Sep 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 3, 2025
@openjdk
Copy link

openjdk bot commented Sep 3, 2025

@phohensee @wkia Pushed as commit 7842c7d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wkia wkia deleted the bp8347826 branch October 8, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants