-
Notifications
You must be signed in to change notification settings - Fork 232
8347826: Introspector shows wrong method list after 8071693 #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into |
|
@wkia This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 264 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request I'd like to backport this to 17u. The backport is almost clean. PR checks are OK. This backport fixes the wrong method and property list returning by Introspector broken after 8071693 in 17.0.14. |
|
Hi, this request is about backporting fix to Java 17 (JDK-8347826). Backport request for same fix on Java 21 was completed 2 weeks back (JDK-8358779). If someone can take a look, it would be very helpful. |
|
@GoeLin , Sir, you validated same request for JDK21 last month. Can you please help to move this PR as well. |
|
@wkia, PR still pending approval. We are eagerly waiting for it to merge in main branch so that we are able to upgrade to latest stable JDK17. |
|
@anuj-ion AFAIU the change was deferred to the next release, at least the JDK bug's label seems so. |
|
@wkia , Ah, I didn't notice the label. Thanks for sharing this info. Will it be a candidate for 17.0.18? |
|
@anuj-ion yes, I hope so. |
|
@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@wkia The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
I would prefer that changes have some exposure in a higher release before they are brought to 17. But as this fixes a regression let's go. |
|
Checked: The modified test fails without the fix, and passes after the fix is applied on the latest master. |
|
/integrate |
|
/sponsor |
|
Going to push as commit 7842c7d.
Your commit was automatically rebased without conflicts. |
|
@phohensee @wkia Pushed as commit 7842c7d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is backport of "8347826: Introspector shows wrong method list after 8071693"
The backport is almost clean, the only conflicts were in copyright year in 2 files.
The modified test fails without the fix, and passes after the fix is applied.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3618/head:pull/3618$ git checkout pull/3618Update a local copy of the PR:
$ git checkout pull/3618$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3618/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3618View PR using the GUI difftool:
$ git pr show -t 3618Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3618.diff
Using Webrev
Link to Webrev Comment