8284458: CodeHeapState::aggregate() leaks blob_name

[zhengyu123]

I would like to backport this patch to 17u to fix a memory leak.

The original patch does not apply cleanly, due to JDK-8275729 and JDK-8276429 that are not in 17u. However, the patch is small and resolved manually.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8284458: CodeHeapState::aggregate() leaks blob_name

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/364/head:pull/364
$ git checkout pull/364

Update a local copy of the PR:
$ git checkout pull/364
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/364/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 364

View PR using the GUI difftool:
$ git pr show -t 364

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/364.diff

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (366481e8)

[TheRealMDoerr]

Looks like a clean backport except Copyright year change. Good.

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284458: CodeHeapState::aggregate() leaks blob_name

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 2a799c8: 8283422: Create a new test for JDK-8254790

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

Thanks, @TheRealMDoerr

[zhengyu123]

/integrate

[openjdk]

Going to push as commit 1cbe38a.
Since your change was applied there have been 8 commits pushed to the master branch:

• 6793a6a: 8284866: Add test to JDK-8273056
• 740e6b1: 8278519: serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java failed "assert(handle != __null) failed: JNI handle should not be null"
• 6f109a4: 8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread
• 11d3c00: 8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME"
• 73c292a: 8282142: [TestCase] compiler/inlining/ResolvedClassTest.java will fail when --with-jvm-features=-compiler1
• b18783d: 8285342: Zero build failure with clang due to values not handled in switch
• 90d4233: 8284622: Update versions of some Github Actions used in JDK workflow
• 2a799c8: 8283422: Create a new test for JDK-8254790

Your commit was automatically rebased without conflicts.

[openjdk]

@zhengyu123 Pushed as commit 1cbe38a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.