8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport #3693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport for RandomSupport issue. There is a loss of information when using convertSeedBytesToLongs() with a bad seed, causing a lot of the original bytes to be overwritten by 1s. The fix involves using a bitwise AND with the seed before distributing the seed bytes into the result.
Clean backport, ran GHA sanity checks and locally tested tier1, tier2.
Progress
Issue
Backport <hash>with the hash of the original commit. See Backports.Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3693/head:pull/3693$ git checkout pull/3693Update a local copy of the PR:
$ git checkout pull/3693$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3693/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3693View PR using the GUI difftool:
$ git pr show -t 3693Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3693.diff
Using Webrev
Link to Webrev Comment