New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head #372
Conversation
Update JDK-8284548 patch with upstream changes.
|
Webrevs
|
Ok, basically a test replacement. May be helpful for future backports.
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
GHA failure gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1 on Linux/x86 is unrelated (and occurs sporadically). |
/integrate |
Going to push as commit c464f20.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit c464f20. |
The upstream patch for JDK-8284548 differs from the version in jdk17u-dev.
In particular the testcase is different. So I think we should update to the code in head to reduce diffs.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/372/head:pull/372
$ git checkout pull/372
Update a local copy of the PR:
$ git checkout pull/372
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/372/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 372
View PR using the GUI difftool:
$ git pr show -t 372
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/372.diff