8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head #373
Speaking from them code itself, without considering maintainability and possible future merges from the head.
So DOT returns. I think this creates an opportunity for a mistake. IMHO, it's even will be worse, it's will be possible to write
Worth to note the new DOT_STR is not aligned stylistically with the rest of String tokens like DDOT and DCOLON, so I don't feel the new change is elegant, but it is a matter of personal taste.
Having a test will be great.
OK, sorry, I shouldn't have used the word "elegant" without really looking at the implementation. What I rather wanted to point out was the fact that Oracle's change was touching less LOC.
I think, after all, we should have the same code in all OpenJDK versions. That's why I would still suggest to do this backport and additionally improve the implementation in OpenJDK head and then backport this enhancement. WDYT?
@AntonKozlov, would you mind proposing your changes in jdk/jdk?
@RealCLanger This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been no new commits pushed to the
➡️ To integrate this PR with the above commit message to the
Going to push as commit a95482a.
Your commit was automatically rebased without conflicts.