Skip to content

8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

reinrich
Copy link
Member

@reinrich reinrich commented Apr 29, 2022

Hi all,

This pull request contains a backport of commit c936e705 from the openjdk/jdk repository.

The commit being backported was authored by Richard Reingruber on 4 Feb 2022 and was reviewed by Martin Doerr and Lutz Schmidt.

Thanks!
Richard.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/376/head:pull/376
$ git checkout pull/376

Update a local copy of the PR:
$ git checkout pull/376
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/376/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 376

View PR using the GUI difftool:
$ git pr show -t 376

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/376.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 29, 2022

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c936e7059b848d0e0be5f3234c4367657f2af2a7 8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 0e6959d: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
  • 14f38e1: 8284992: Fix misleading Vector API doc for LSHR operator
  • 523a4c4: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • a95482a: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head
  • c464f20: 8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head
  • e5a71d7: 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value
  • a839a36: 8286029: Add classpath exemption to globals_vectorApiSupport_***.S.inc
  • 75cfc99: 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo
  • cf2b20f: 8284532: Memory leak in BitSet::BitMapFragmentTable in JFR leak profiler
  • 70d3583: 8282170: JVMTI SetBreakpoint metaspace allocation test
  • ... and 7 more: https://git.openjdk.java.net/jdk17u-dev/compare/ae9b3344901182f4268bcaba353b0802052014f9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 29, 2022
@reinrich reinrich marked this pull request as ready for review May 9, 2022 13:06
@openjdk openjdk bot added the rfr Pull request is ready for review label May 9, 2022
@mlbridge
Copy link

mlbridge bot commented May 9, 2022

Webrevs

@reinrich
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 12, 2022

Going to push as commit bbd500f.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 230cd5e: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
  • 296dc78: 8268773: Improvements related to: Failed to start thread - pthread_create failed (EAGAIN)
  • b6404c8: 8282008: Incorrect handling of quoted arguments in ProcessBuilder
  • 31eefe5: 8284848: C2: Compiler blackhole arguments should be treated as globally escaping
  • c735f55: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 1b1500a: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use
  • 0e6959d: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
  • 14f38e1: 8284992: Fix misleading Vector API doc for LSHR operator
  • 523a4c4: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • a95482a: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head
  • ... and 13 more: https://git.openjdk.java.net/jdk17u-dev/compare/ae9b3344901182f4268bcaba353b0802052014f9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 12, 2022
@openjdk openjdk bot closed this May 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 12, 2022
@openjdk
Copy link

openjdk bot commented May 12, 2022

@reinrich Pushed as commit bbd500f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant