8284848: C2: Compiler blackhole arguments should be treated as globally escaping

[shipilev]

Unclean backport to improve Blackhole - EA interactions. The backport is not clean, because IRNode needs missing constants, and set_escape_state does not accept third argument (description) in 18u.

Additional testing:

• compiler/c2/irTests/blackhole fail without the patch, pass with it
• compiler/blackhole continue to pass

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 reviews required, with at least 1 reviewer)

Issue

• JDK-8284848: C2: Compiler blackhole arguments should be treated as globally escaping

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 63dff48a

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/379/head:pull/379
$ git checkout pull/379

Update a local copy of the PR:
$ git checkout pull/379
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/379/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 379

View PR using the GUI difftool:
$ git pr show -t 379

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/379.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (e64e3e15)
• 00: Full (63dff48a)

[vnkozlov]

Good

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284848: C2: Compiler blackhole arguments should be treated as globally escaping

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Got the push approval.

/integrate

[openjdk]

Going to push as commit 31eefe5.
Since your change was applied there have been 11 commits pushed to the master branch:

• c735f55: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
• 1b1500a: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use
• 0e6959d: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
• 14f38e1: 8284992: Fix misleading Vector API doc for LSHR operator
• 523a4c4: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
• a95482a: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head
• c464f20: 8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head
• e5a71d7: 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value
• a839a36: 8286029: Add classpath exemption to globals_vectorApiSupport_***.S.inc
• 75cfc99: 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo
• ... and 1 more: https://git.openjdk.java.net/jdk17u-dev/compare/70d35833409c44fa435ac231062c321681d0ab7f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 31eefe5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.