Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 5, 2025

I backport this as follow-up to JDK-8349583. This needs to go along with this change and is independent of Java version.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8355779 needs maintainer approval

Issue

  • JDK-8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3820/head:pull/3820
$ git checkout pull/3820

Update a local copy of the PR:
$ git checkout pull/3820
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3820/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3820

View PR using the GUI difftool:
$ git pr show -t 3820

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3820.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/3810 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 5, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 34807df7627b067f750578987c941213a5f8336a 8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension Aug 5, 2025
@openjdk
Copy link

openjdk bot commented Aug 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Aug 5, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 5, 2025

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 7, 2025
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/3810 to master August 7, 2025 09:23
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8355779
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Aug 7, 2025
@openjdk
Copy link

openjdk bot commented Aug 7, 2025

@GoeLin this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout goetz_backport_8355779
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch and removed approval Requires approval; will be removed when approval is received labels Aug 7, 2025
@GoeLin GoeLin force-pushed the goetz_backport_8355779 branch from 0a1e54b to 23dfd39 Compare August 8, 2025 09:53
@openjdk
Copy link

openjdk bot commented Aug 8, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added clean Identical backport; no merge resolution required ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Aug 8, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Aug 13, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

Going to push as commit 70b4f5b.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 13, 2025
@openjdk openjdk bot closed this Aug 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 13, 2025
@openjdk
Copy link

openjdk bot commented Aug 13, 2025

@GoeLin Pushed as commit 70b4f5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8355779 branch August 13, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant