-
Notifications
You must be signed in to change notification settings - Fork 232
8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension #3820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8355779
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
@GoeLin this pull request can not be integrated into git checkout goetz_backport_8355779
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
0a1e54b to
23dfd39
Compare
|
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
/integrate |
|
Going to push as commit 70b4f5b.
Your commit was automatically rebased without conflicts. |
I backport this as follow-up to JDK-8349583. This needs to go along with this change and is independent of Java version.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3820/head:pull/3820$ git checkout pull/3820Update a local copy of the PR:
$ git checkout pull/3820$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3820/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3820View PR using the GUI difftool:
$ git pr show -t 3820Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3820.diff
Using Webrev
Link to Webrev Comment