Skip to content

8285956: (fs) Excessive default poll interval in PollingWatchService #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

backwaterred
Copy link
Contributor

@backwaterred backwaterred commented May 5, 2022

This PR backports changes that reduce the wait time for a user of the WatchService API on AIX and BSD.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285956: (fs) Excessive default poll interval in PollingWatchService

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/384/head:pull/384
$ git checkout pull/384

Update a local copy of the PR:
$ git checkout pull/384
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/384/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 384

View PR using the GUI difftool:
$ git pr show -t 384

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/384.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2022

👋 Welcome back backwaterred! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1bb4de2e2868a539846ec48dd43fd623c2ba69a5 8285956: (fs) Excessive default poll interval in PollingWatchService May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 5, 2022

@backwaterred This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285956: (fs) Excessive default poll interval in PollingWatchService

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • bbd500f: 8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor
  • 230cd5e: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
  • 296dc78: 8268773: Improvements related to: Failed to start thread - pthread_create failed (EAGAIN)
  • b6404c8: 8282008: Incorrect handling of quoted arguments in ProcessBuilder
  • 31eefe5: 8284848: C2: Compiler blackhole arguments should be treated as globally escaping
  • c735f55: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 1b1500a: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use
  • 0e6959d: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
  • 14f38e1: 8284992: Fix misleading Vector API doc for LSHR operator
  • 523a4c4: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • ... and 4 more: https://git.openjdk.java.net/jdk17u-dev/compare/75cfc998ebbfa130e517bc387c828789e0210847...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 5, 2022
@mlbridge
Copy link

mlbridge bot commented May 5, 2022

Webrevs

@backwaterred
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 12, 2022
@openjdk
Copy link

openjdk bot commented May 12, 2022

@backwaterred
Your change (at version ae5f9cb) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 12, 2022

Going to push as commit f9a6e0c.
Since your change was applied there have been 14 commits pushed to the master branch:

  • bbd500f: 8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor
  • 230cd5e: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
  • 296dc78: 8268773: Improvements related to: Failed to start thread - pthread_create failed (EAGAIN)
  • b6404c8: 8282008: Incorrect handling of quoted arguments in ProcessBuilder
  • 31eefe5: 8284848: C2: Compiler blackhole arguments should be treated as globally escaping
  • c735f55: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 1b1500a: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use
  • 0e6959d: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
  • 14f38e1: 8284992: Fix misleading Vector API doc for LSHR operator
  • 523a4c4: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • ... and 4 more: https://git.openjdk.java.net/jdk17u-dev/compare/75cfc998ebbfa130e517bc387c828789e0210847...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 12, 2022
@openjdk openjdk bot closed this May 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 12, 2022
@openjdk
Copy link

openjdk bot commented May 12, 2022

@TheRealMDoerr @backwaterred Pushed as commit f9a6e0c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants