8347373: HTTP/2 flow control checks may count unprocessed data twice

[GoeLin]

I backport this for parity with 21.0.8-oracle and as follow-up of JDK-8342075.

I had to do a small resolve in Http2TestServerConnection.java.

The original has one more else block with printouts that were adapted. This was added by https://bugs.openjdk.org/browse/JDK-8303481: CancelRequestTest assertTrue failing with AssertionError due to java.util.concurrent.CompletionException: java.io.EOFException: EOF reached while reading

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8347373 needs maintainer approval

Issue

• JDK-8347373: HTTP/2 flow control checks may count unprocessed data twice (Bug - P4 - Approved)

Reviewers

• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3857/head:pull/3857
$ git checkout pull/3857

Update a local copy of the PR:
$ git checkout pull/3857
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3857/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3857

View PR using the GUI difftool:
$ git pr show -t 3857

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3857.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/3852 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347373: HTTP/2 flow control checks may count unprocessed data twice

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 87949a2: 8293713: java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher
• 688c36b: 8348328: Update IANA Language Subtag Registry to Version 2025-05-15
• 69a182d: 8353549: Open source events tests batch2
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/9b71cd68dc750f2996334300e716deec091eda04...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full (e14e0c59)
• 01: Full (c3083b3b)
• 00: Full (45e8d493)

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

⚠️ @GoeLin This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[GoeLin]

GHA Failure: unrelated to this change
langtools ToolTabSnippetTest: java.lang.Exception: failures: 1

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8347373
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@GoeLin this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout goetz_backport_8347373
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[schmelter-sap]

Looks good.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

/integrate

[openjdk]

Going to push as commit f937b24.
Since your change was applied there have been 7 commits pushed to the master branch:

• 7b77ad3: 8353213: Open source several swing tests batch3
• 6db60fd: 8353000: Open source several swing tests batch2
• ae8db19: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly"
• ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/9b71cd68dc750f2996334300e716deec091eda04...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit f937b24.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.