8282008: Incorrect handling of quoted arguments in ProcessBuilder

[omikhaltsova]

I'd like to backport JDK-8282008 to jdk17u.
The original patch applied cleanly.
Tested on Windows. All regular tests passed.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-8282008: Incorrect handling of quoted arguments in ProcessBuilder
• JDK-8282989: Incorrect handling of quoted arguments in ProcessBuilder on Windows (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/386/head:pull/386
$ git checkout pull/386

Update a local copy of the PR:
$ git checkout pull/386
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/386/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 386

View PR using the GUI difftool:
$ git pr show -t 386

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/386.diff

[bridgekeeper]

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@omikhaltsova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282008: Incorrect handling of quoted arguments in ProcessBuilder

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 75cfc99: 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo
• cf2b20f: 8284532: Memory leak in BitSet::BitMapFragmentTable in JFR leak profiler
• 70d3583: 8282170: JVMTI SetBreakpoint metaspace allocation test
• 0955aca: 8285394: Compiler blackholes can be eliminated due to stale ciMethod::intrinsic_id()
• db26df6: 8284549: JFR: FieldTable leaks FieldInfoTable member
• a1da138: 8284620: CodeBuffer may leak _overflow_arena
• c1e1719: 8274735: javax.imageio.IIOException: Unsupported Image Type while processing a valid JPEG image
• bb7b764: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
• 40c7bf2: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive
• d67ca11: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
• ... and 3 more: https://git.openjdk.java.net/jdk17u-dev/compare/6793a6a43db7032ffe22a30e25212403c2a91063...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (10ff07d4)

[GoeLin]

Hi @omikhaltsova
please enable github actions for this repo.
Thanks.

[omikhaltsova]

@GoeLin Thanks for the reminder! The github actions for this repo is enabled.
The pre-submit tests were run manually for the branch of my fork of this pr.

[omikhaltsova]

/integrate

[openjdk]

Going to push as commit b6404c8.
Since your change was applied there have been 23 commits pushed to the master branch:

• 31eefe5: 8284848: C2: Compiler blackhole arguments should be treated as globally escaping
• c735f55: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
• 1b1500a: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use
• 0e6959d: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
• 14f38e1: 8284992: Fix misleading Vector API doc for LSHR operator
• 523a4c4: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
• a95482a: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head
• c464f20: 8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head
• e5a71d7: 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value
• a839a36: 8286029: Add classpath exemption to globals_vectorApiSupport_***.S.inc
• ... and 13 more: https://git.openjdk.java.net/jdk17u-dev/compare/6793a6a43db7032ffe22a30e25212403c2a91063...master

Your commit was automatically rebased without conflicts.

[openjdk]

@omikhaltsova Pushed as commit b6404c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.