Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Aug 25, 2025

Improves GHA performance.

Additional testing:

  • GHA

Progress

  • JDK-8361478 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361478: GHA: Use MSYS2 from GHA runners (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3872/head:pull/3872
$ git checkout pull/3872

Update a local copy of the PR:
$ git checkout pull/3872
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3872/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3872

View PR using the GUI difftool:
$ git pr show -t 3872

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3872.diff

Using Webrev

Link to Webrev Comment

@shipilev shipilev marked this pull request as ready for review August 25, 2025 09:34
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361478: GHA: Use MSYS2 from GHA runners

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 880c9e0: 8353748: Open source several swing tests batch6

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ed9066bdf48c2d9925aea745951531ebf4af35a8 8361478: GHA: Use MSYS2 from GHA runners Aug 25, 2025
@openjdk
Copy link

openjdk bot commented Aug 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 25, 2025
@openjdk
Copy link

openjdk bot commented Aug 25, 2025

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 25, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2025

Webrevs

@shipilev
Copy link
Member Author

/approval request Improves GHA performance. The patch was in mainline for a few weeks, and we have seen no problems with it. Applies cleanly. Risk is low: GHA only patch.

@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@shipilev
8361478: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 25, 2025
@shipilev
Copy link
Member Author

Push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 27, 2025

Going to push as commit f682f48.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 880c9e0: 8353748: Open source several swing tests batch6

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 27, 2025
@openjdk openjdk bot closed this Aug 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 27, 2025
@openjdk
Copy link

openjdk bot commented Aug 27, 2025

@shipilev Pushed as commit f682f48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant