Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278824: Uneven work distribution when scanning heap roots in G1 #39

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Dec 28, 2021

Resolved a conflict in a comment.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278824: Uneven work distribution when scanning heap roots in G1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/39/head:pull/39
$ git checkout pull/39

Update a local copy of the PR:
$ git checkout pull/39
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/39/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 39

View PR using the GUI difftool:
$ git pr show -t 39

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/39.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 28, 2021

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 28, 2021

⚠️ @earthling-amzn could not find any commit with hash b4b0328d62d9a9646f2822c361e41001bf0d4aa0. Please update the title with the hash for an existing commit.

@openjdk openjdk bot changed the title Backport b4b0328d62d9a9646f2822c361e41001bf0d4aa0 8278824: Uneven work distribution when scanning heap roots in G1 Dec 28, 2021
@openjdk
Copy link

openjdk bot commented Dec 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 28, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 28, 2021

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Dec 28, 2021

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278824: Uneven work distribution when scanning heap roots in G1

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 28, 2021
@earthling-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 28, 2021
@openjdk
Copy link

openjdk bot commented Dec 28, 2021

@earthling-amzn
Your change (at version 81b9978) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 6, 2022

Going to push as commit 3b5fc8c.
Since your change was applied there have been 22 commits pushed to the master branch:

  • de2e289: 8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with EXCEPTION_ACCESS_VIOLATION at 0x000000000000000d
  • 4a188e9: 8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording
  • ca59b64: 8277342: vmTestbase/nsk/stress/strace/strace004.java fails with SIGSEGV in InstanceKlass::jni_id_for
  • 9acabeb: 8278104: C1 should support the compiler directive 'BreakAtExecute'
  • 0ccdda4: 8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures
  • 775e81d: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • bd28050: 8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux
  • a471f7a: 8275800: Redefinition leaks MethodData::_extra_data_lock
  • ccb5f86: 8273634: [TEST_BUG] Improve javax/swing/text/ParagraphView/6364882/bug6364882.java
  • 8e6ed88: 8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never fails
  • ... and 12 more: https://git.openjdk.java.net/jdk17u-dev/compare/6aa60ac1dfbc3f93feee73635e29dabf9e4ababe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 6, 2022
@openjdk openjdk bot closed this Jan 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 6, 2022
@openjdk
Copy link

openjdk bot commented Jan 6, 2022

@phohensee @earthling-amzn Pushed as commit 3b5fc8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants