Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283323: libharfbuzz optimization level results in extreme build times #392

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented May 11, 2022

Clean backport of JDK-8283323


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283323: libharfbuzz optimization level results in extreme build times

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/392/head:pull/392
$ git checkout pull/392

Update a local copy of the PR:
$ git checkout pull/392
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/392/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 392

View PR using the GUI difftool:
$ git pr show -t 392

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/392.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2c43ecb43fa3c94b69478039f1cd70ed4a577768 8283323: libharfbuzz optimization level results in extreme build times May 11, 2022
@openjdk
Copy link

openjdk bot commented May 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 11, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283323: libharfbuzz optimization level results in extreme build times

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 11, 2022
@mlbridge
Copy link

mlbridge bot commented May 11, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 13, 2022

Going to push as commit 5c1835d.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 7cef5a5: 8286198: [linux] Fix process-memory information
  • f9a6e0c: 8285956: (fs) Excessive default poll interval in PollingWatchService
  • bbd500f: 8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor
  • 230cd5e: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
  • 296dc78: 8268773: Improvements related to: Failed to start thread - pthread_create failed (EAGAIN)
  • b6404c8: 8282008: Incorrect handling of quoted arguments in ProcessBuilder
  • 31eefe5: 8284848: C2: Compiler blackhole arguments should be treated as globally escaping

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 13, 2022
@openjdk openjdk bot closed this May 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2022
@openjdk
Copy link

openjdk bot commented May 13, 2022

@TheRealMDoerr Pushed as commit 5c1835d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant