8341138: Rename jtreg property docker.support as container.support#3924
8341138: Rename jtreg property docker.support as container.support#3924GoeLin wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
GHA failure: crash in C2 on macos x86. Twice the same crash! |
55351cb to
e625d1c
Compare
|
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
|
|
/integrate |
|
Going to push as commit d2302a8.
Your commit was automatically rebased without conflicts. |
I backport this to make later backports clean.
test/hotspot/jtreg/TEST.ROOT
test/jdk/TEST.ROOT
Resolved due to context.
test/hotspot/jtreg/containers/docker/TestJFREvents.java
Resolved due to context.
test/jdk/jdk/internal/platform/docker/TestGetFreeSwapSpaceSize.java
Resolved Copyright due to context.
test/jtreg-ext/requires/VMProps.java
Several larger resolves and additional edits needed.
'
Update:
This change depends on a refactoring in VMProps.java. No big thing,
but not nice as this test support coding has frequent updates in backports
and thus it's useful to keep it as close to head as possible.
The refactoring came with "8333446: Add tests for hierarchical container support"
a change that on first sight looks like a nice want-to-have for 17, especially as it
backports clean. But it depends on larger functional changes in 21 we do
not want to backport to 17.
So I now decided to take the refactoring of VMProps from 8333446 and include
it in this change, see also the first commit.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3924/head:pull/3924$ git checkout pull/3924Update a local copy of the PR:
$ git checkout pull/3924$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3924/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3924View PR using the GUI difftool:
$ git pr show -t 3924Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3924.diff
Using Webrev
Link to Webrev Comment