Skip to content

8356187: TestJcmd.java may incorrectly parse podman version#3932

Closed
GoeLin wants to merge 2 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8356187
Closed

8356187: TestJcmd.java may incorrectly parse podman version#3932
GoeLin wants to merge 2 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8356187

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 15, 2025

I backport this for parity with 17.0.18-oracle

resolved copyright, probably clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8356187 needs maintainer approval

Issue

  • JDK-8356187: TestJcmd.java may incorrectly parse podman version (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3932/head:pull/3932
$ git checkout pull/3932

Update a local copy of the PR:
$ git checkout pull/3932
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3932/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3932

View PR using the GUI difftool:
$ git pr show -t 3932

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3932.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 15, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356187: TestJcmd.java may incorrectly parse podman version

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 328715d84c0eafb4fe58d28b301138374ddac168 8356187: TestJcmd.java may incorrectly parse podman version Sep 15, 2025
@openjdk
Copy link

openjdk bot commented Sep 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 15, 2025
@openjdk
Copy link

openjdk bot commented Sep 15, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2025

Webrevs

@GoeLin GoeLin marked this pull request as draft September 15, 2025 14:48
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 15, 2025
@GoeLin GoeLin marked this pull request as ready for review September 22, 2025 11:34
@openjdk openjdk bot added rfr Pull request is ready for review approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 22, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Sep 23, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Sep 23, 2025

Going to push as commit 3f9350c.
Since your change was applied there have been 10 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 23, 2025
@openjdk openjdk bot closed this Sep 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 23, 2025
@openjdk
Copy link

openjdk bot commented Sep 23, 2025

@GoeLin Pushed as commit 3f9350c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8356187 branch September 23, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant