New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8285523: Improve test java/io/FileOutputStream/OpenNUL.java #398
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Hi @mrserb, |
Some unrelated test failed on linux, the test changed by this PR is windows only. |
/integrate |
Going to push as commit 817457e.
Your commit was automatically rebased without conflicts. |
Hi all,
This pull request contains a backport of commit f42631e3 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 29 Apr 2022 and was reviewed by Andrew John Hughes and Brian Burkhalter.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/398/head:pull/398
$ git checkout pull/398
Update a local copy of the PR:
$ git checkout pull/398
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/398/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 398
View PR using the GUI difftool:
$ git pr show -t 398
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/398.diff