Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285523: Improve test java/io/FileOutputStream/OpenNUL.java #398

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 15, 2022

Hi all,
This pull request contains a backport of commit f42631e3 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 29 Apr 2022 and was reviewed by Andrew John Hughes and Brian Burkhalter.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285523: Improve test java/io/FileOutputStream/OpenNUL.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/398/head:pull/398
$ git checkout pull/398

Update a local copy of the PR:
$ git checkout pull/398
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/398/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 398

View PR using the GUI difftool:
$ git pr show -t 398

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/398.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f42631e354d4abf7994abd92aa5def6b2ceeab3a 8285523: Improve test java/io/FileOutputStream/OpenNUL.java May 15, 2022
@openjdk
Copy link

openjdk bot commented May 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 15, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285523: Improve test java/io/FileOutputStream/OpenNUL.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 5c1835d: 8283323: libharfbuzz optimization level results in extreme build times
  • 7cef5a5: 8286198: [linux] Fix process-memory information
  • f9a6e0c: 8285956: (fs) Excessive default poll interval in PollingWatchService
  • bbd500f: 8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor
  • 230cd5e: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
  • 296dc78: 8268773: Improvements related to: Failed to start thread - pthread_create failed (EAGAIN)
  • b6404c8: 8282008: Incorrect handling of quoted arguments in ProcessBuilder
  • 31eefe5: 8284848: C2: Compiler blackhole arguments should be treated as globally escaping
  • c735f55: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 1b1500a: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use
  • ... and 13 more: https://git.openjdk.java.net/jdk17u-dev/compare/c1e17197222932a03a04d3b8d9c0d7f94be07947...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 15, 2022
@mrserb mrserb marked this pull request as ready for review May 15, 2022 23:25
@openjdk openjdk bot added the rfr Pull request is ready for review label May 15, 2022
@mlbridge
Copy link

mlbridge bot commented May 15, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented May 16, 2022

Hi @mrserb,
what is wrong with the Pre-submit tests? Is the test failing?
Thanks, Goetz

@mrserb
Copy link
Member Author

mrserb commented May 20, 2022

Hi @mrserb, what is wrong with the Pre-submit tests? Is the test failing? Thanks, Goetz

Some unrelated test failed on linux, the test changed by this PR is windows only.

@mrserb
Copy link
Member Author

mrserb commented May 20, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 20, 2022

Going to push as commit 817457e.
Since your change was applied there have been 32 commits pushed to the master branch:

  • c94a235: 8209776: Refactor jdk/security/JavaDotSecurity/ifdefs.sh to plain java test
  • d70f90b: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  • 0355888: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak
  • ab81cd0: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
  • 676b097: 8236136: tests which use CompilationMode shouldn't be run w/ TieredStopAtLevel
  • fc81c86: 8285686: Update FreeType to 2.12.0
  • 2680e83: 8285728: Alpine Linux build fails with busybox tar
  • cc91c6e: 8284758: [linux] improve print_container_info
  • 7c87493: 8284754: print more interesting env variables in hs_err and VM.info
  • 5c1835d: 8283323: libharfbuzz optimization level results in extreme build times
  • ... and 22 more: https://git.openjdk.java.net/jdk17u-dev/compare/c1e17197222932a03a04d3b8d9c0d7f94be07947...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 20, 2022
@openjdk openjdk bot closed this May 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 20, 2022
@openjdk
Copy link

openjdk bot commented May 20, 2022

@mrserb Pushed as commit 817457e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants