Skip to content

Conversation

@satyenme
Copy link

@satyenme satyenme commented Sep 22, 2025

Backporting JDK-8328247: Remove redundant dir for tests converted from applet to main. Renames three javax swing tests, as per change accepted by Oracle.

Notably, this change also adapts JDK-8355333: Some Problem list entries point to non-existent / wrong files, to ensure that the renamed files are correctly excluded. I'm also removing the PrintToFileTest tests from the exclude list (since these only run on windows anyway). The ScrollPaneEventType.java test hasn't been backported yet (I'll follow up with another PR doing so and excluding as needed), so I've left that change out.

Ran GHA Sanity Checks, local Tier 1 and 2, and new tests directly. Patch is clean. Backporting for parity with Oracle.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8328247 needs maintainer approval
  • Change must not contain extraneous whitespace
  • JDK-8355333 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8353958 needs maintainer approval

Issues

  • JDK-8328247: Remove redundant dir for tests converted from applet to main (Bug - P4 - Requested)
  • JDK-8355333: Some Problem list entries point to non-existent / wrong files (Bug - P4)
  • JDK-8353958: Open source several AWT ScrollPane tests - Batch 2 (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3985/head:pull/3985
$ git checkout pull/3985

Update a local copy of the PR:
$ git checkout pull/3985
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3985/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3985

View PR using the GUI difftool:
$ git pr show -t 3985

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3985.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 22, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ece4124f25f676da9bf2d1b7fd8e4394dd7d31af 8328247: Remove redundant dir for tests converted from applet to main Sep 22, 2025
@openjdk
Copy link

openjdk bot commented Sep 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 22, 2025
@satyenme
Copy link
Author

/issue 8355333

@mlbridge
Copy link

mlbridge bot commented Sep 22, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 22, 2025

@satyenme
Adding additional issue to issue list: 8355333: Some Problem list entries point to non-existent / wrong files.

@satyenme
Copy link
Author

/issue 8353958

@openjdk
Copy link

openjdk bot commented Sep 26, 2025

@satyenme Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Sep 26, 2025

@satyenme
Adding additional issue to issue list: 8353958: Open source several AWT ScrollPane tests - Batch 2.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 29, 2025
@satyenme satyenme closed this Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant