Skip to content

Conversation

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Oct 2, 2025

Clean backport from JDK 21u. Should be low risk. Affects newer development systems on Linux, like F41+, where memory limits aren't properly detected.

Container tests fail on affected systems (before the patch):

Passed: containers/cgroup/CgroupSubsystemFactory.java
Passed: containers/cgroup/PlainRead.java
Passed: containers/docker/DockerBasicTest.java
Passed: containers/docker/ShareTmpDir.java
Passed: containers/docker/TestContainerInfo.java
FAILED: containers/docker/TestCPUAwareness.java
FAILED: containers/docker/TestCPUSets.java
Passed: containers/docker/TestJcmd.java
Passed: containers/docker/TestJcmdWithSideCar.java
FAILED: containers/docker/TestJFREvents.java
Passed: containers/docker/TestJFRNetworkEvents.java
Passed: containers/docker/TestJFRWithJMX.java
FAILED: containers/docker/TestLimitsUpdating.java
FAILED: containers/docker/TestMemoryAwareness.java
Passed: containers/docker/TestMemoryWithCgroupV1.java
FAILED: containers/docker/TestMisc.java
FAILED: containers/docker/TestPids.java
Test results: passed: 10; failed: 7; skipped: 1

Caused by:

 stdout: [[0.000s][trace][os,container] OSContainer::init: Initializing Container Support
[0.000s][debug][os,container] Detected optional pids controller entry in /proc/cgroups
[0.000s][debug][os,container] controller cpu is not enabled

[0.000s][debug][os,container] One or more required controllers disabled at kernel level.
openjdk version "17.0.18-internal" 2026-01-20
OpenJDK Runtime Environment (fastdebug build 17.0.18-internal+0-adhoc.sgehwolf.jdk17u-dev)
OpenJDK 64-Bit Server VM (fastdebug build 17.0.18-internal+0-adhoc.sgehwolf.jdk17u-dev, mixed mode, sharing)
];
 stderr: []
 exitValue = 0

java.lang.RuntimeException: 'active_processor_count.*1' missing from stdout/stderr

Testing after the patch (on an affected system):

Passed: containers/cgroup/CgroupSubsystemFactory.java
Passed: containers/cgroup/PlainRead.java
Passed: containers/docker/DockerBasicTest.java
Passed: containers/docker/ShareTmpDir.java
Passed: containers/docker/TestContainerInfo.java
Passed: containers/docker/TestCPUAwareness.java
Passed: containers/docker/TestCPUSets.java
Passed: containers/docker/TestJcmd.java
Passed: containers/docker/TestJcmdWithSideCar.java
Passed: containers/docker/TestJFREvents.java
Passed: containers/docker/TestJFRNetworkEvents.java
Passed: containers/docker/TestJFRWithJMX.java
Passed: containers/docker/TestLimitsUpdating.java
Passed: containers/docker/TestMemoryAwareness.java
Passed: containers/docker/TestMemoryWithCgroupV1.java
Passed: containers/docker/TestMisc.java
Passed: containers/docker/TestPids.java
Test results: passed: 17

After patch on cgroup v1 (no-op there):

Passed: containers/cgroup/CgroupSubsystemFactory.java
Passed: containers/cgroup/PlainRead.java
Passed: containers/docker/DockerBasicTest.java
Passed: containers/docker/ShareTmpDir.java
Passed: containers/docker/TestContainerInfo.java
Passed: containers/docker/TestCPUAwareness.java
Passed: containers/docker/TestCPUSets.java
Passed: containers/docker/TestJcmd.java
Passed: containers/docker/TestJcmdWithSideCar.java
Passed: containers/docker/TestJFREvents.java
Passed: containers/docker/TestJFRNetworkEvents.java
Passed: containers/docker/TestJFRWithJMX.java
Passed: containers/docker/TestLimitsUpdating.java
Passed: containers/docker/TestMemoryAwareness.java
Passed: containers/docker/TestMemoryWithCgroupV1.java
Passed: containers/docker/TestMisc.java
Passed: containers/docker/TestPids.java
Test results: passed: 17; skipped: 1

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8347129 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8347129: cpuset cgroups controller is required for no good reason

Issue

  • JDK-8347129: cpuset cgroups controller is required for no good reason (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4009/head:pull/4009
$ git checkout pull/4009

Update a local copy of the PR:
$ git checkout pull/4009
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4009/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4009

View PR using the GUI difftool:
$ git pr show -t 4009

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4009.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2025

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 2, 2025

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347129: cpuset cgroups controller is required for no good reason

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport be245be258cda7e06366b4051eec24ad6df04f20 8347129: cpuset cgroups controller is required for no good reason Oct 2, 2025
@openjdk
Copy link

openjdk bot commented Oct 2, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 2, 2025
@jerboaa jerboaa marked this pull request as ready for review October 2, 2025 17:20
@openjdk
Copy link

openjdk bot commented Oct 2, 2025

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 2, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 6, 2025
@jerboaa
Copy link
Contributor Author

jerboaa commented Oct 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 7, 2025

Going to push as commit 7828779.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 7, 2025
@openjdk openjdk bot closed this Oct 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2025
@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@jerboaa Pushed as commit 7828779.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant