Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 5, 2025

I backport this to improve testing.

Resolved one chunk in Win8301247Test.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8344275 needs maintainer approval

Issue

  • JDK-8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4017/head:pull/4017
$ git checkout pull/4017

Update a local copy of the PR:
$ git checkout pull/4017
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4017/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4017

View PR using the GUI difftool:
$ git pr show -t 4017

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4017.diff

Using Webrev

Link to Webrev Comment

@GoeLin GoeLin marked this pull request as draft October 5, 2025 19:23
@GoeLin GoeLin changed the base branch from master to pr/4015 October 5, 2025 19:23
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the base branch from pr/4015 to pr/4016 October 5, 2025 19:24
@openjdk
Copy link

openjdk bot commented Oct 5, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform

Reviewed-by: phh, asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@GoeLin GoeLin changed the title Goetz backport 8344275 backport 227c430b55e7f9a4257b9249881c8ec75574895c Oct 5, 2025
@openjdk openjdk bot changed the title backport 227c430b55e7f9a4257b9249881c8ec75574895c 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform Oct 5, 2025
@openjdk
Copy link

openjdk bot commented Oct 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Oct 5, 2025
@GoeLin GoeLin marked this pull request as ready for review October 7, 2025 16:14
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 7, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 9, 2025

Thanks for the reviews!

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Oct 9, 2025
@GoeLin GoeLin changed the base branch from pr/4016 to master October 10, 2025 09:15
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 10, 2025

Going to push as commit a829921.
Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2025
@openjdk openjdk bot closed this Oct 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 10, 2025
@openjdk
Copy link

openjdk bot commented Oct 10, 2025

@GoeLin Pushed as commit a829921.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8344275 branch October 10, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants