Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283849: AsyncGetCallTrace may crash JVM on guarantee #402

Closed
wants to merge 3 commits into from

Conversation

jbachorik
Copy link

@jbachorik jbachorik commented May 18, 2022

The backport is applied mainly cleanly with only minor adjustments required.

The change is split into the backport commit and the adjustments commit


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283849: AsyncGetCallTrace may crash JVM on guarantee

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/402/head:pull/402
$ git checkout pull/402

Update a local copy of the PR:
$ git checkout pull/402
$ git pull https://git.openjdk.org/jdk17u-dev pull/402/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 402

View PR using the GUI difftool:
$ git pr show -t 402

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/402.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 18, 2022

👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 93c88690a1c2cbc7ba7fc70ddef9bf5928e4de03 8283849: AsyncGetCallTrace may crash JVM on guarantee May 18, 2022
@openjdk
Copy link

openjdk bot commented May 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 18, 2022
@mlbridge
Copy link

mlbridge bot commented May 18, 2022

Webrevs

@jbachorik jbachorik force-pushed the jbachorik-backport-93c88690 branch from abd2fa1 to fdf6934 Compare May 18, 2022 08:05
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented May 18, 2022

@jbachorik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283849: AsyncGetCallTrace may crash JVM on guarantee

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 18, 2022
@openjdk-notifier
Copy link

@jbachorik Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@jbachorik
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 13, 2022

Going to push as commit 1963985.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2022
@openjdk openjdk bot closed this Jun 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2022
@openjdk
Copy link

openjdk bot commented Jun 13, 2022

@jbachorik Pushed as commit 1963985.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jbachorik jbachorik deleted the jbachorik-backport-93c88690 branch June 13, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants