-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283849: AsyncGetCallTrace may crash JVM on guarantee #402
Conversation
Reviewed-by: dholmes, stuefe
👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
abd2fa1
to
fdf6934
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@jbachorik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
…-backport-93c88690
@jbachorik Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
/integrate |
Going to push as commit 1963985. |
@jbachorik Pushed as commit 1963985. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The backport is applied mainly cleanly with only minor adjustments required.
The change is split into the backport commit and the adjustments commit
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/402/head:pull/402
$ git checkout pull/402
Update a local copy of the PR:
$ git checkout pull/402
$ git pull https://git.openjdk.org/jdk17u-dev pull/402/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 402
View PR using the GUI difftool:
$ git pr show -t 402
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/402.diff