Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8181571: printing to CUPS fails on mac sandbox app #405

Closed

Conversation

AlexanderScherbatiy
Copy link

@AlexanderScherbatiy AlexanderScherbatiy commented May 18, 2022

This is a clean backport of JDK-8181571 printing to CUPS fails on mac sandbox app.

I manually checked that a signed java application with the fix prints a test page when running within the macOS sandbox.

The tests jdk-tier1, jdk-tier2, jdk-tier3 automated tests have been run on Mac M1.
The only failed test on my system is tools/jlink/JLinkTest.java.JLinkTest which fails without the fix as well.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8181571: printing to CUPS fails on mac sandbox app

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/405/head:pull/405
$ git checkout pull/405

Update a local copy of the PR:
$ git checkout pull/405
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/405/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 405

View PR using the GUI difftool:
$ git pr show -t 405

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/405.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 18, 2022

👋 Welcome back alexsch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3d4be14eba60e21d5c10f2ad07a20c018329c563 8181571: printing to CUPS fails on mac sandbox app May 18, 2022
@openjdk
Copy link

openjdk bot commented May 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 18, 2022

@AlexanderScherbatiy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8181571: printing to CUPS fails on mac sandbox app

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 0355888: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak
  • ab81cd0: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
  • 676b097: 8236136: tests which use CompilationMode shouldn't be run w/ TieredStopAtLevel
  • fc81c86: 8285686: Update FreeType to 2.12.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 18, 2022
@mlbridge
Copy link

mlbridge bot commented May 18, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented May 19, 2022

Hi @AlexanderScherbatiy

Can you please make a dependent pull request for JDK-8285397 so they can be pushed together? Please add the fix-request tag in the JBS issue again after this.
Also it seems you did not add alexsch@openjdk.org to your Github account.

Best, Goetz.

@AlexanderScherbatiy
Copy link
Author

The dependent pull request #409 is created for JDK-8285397.

@AlexanderScherbatiy
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2022

Going to push as commit fb234ac.
Since your change was applied there have been 9 commits pushed to the master branch:

  • f78c4bc: 8287119: Add Distrust.java to ProblemList
  • 1fece41: 8139173: [macosx] JInternalFrame shadow is not properly drawn
  • 817457e: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
  • c94a235: 8209776: Refactor jdk/security/JavaDotSecurity/ifdefs.sh to plain java test
  • d70f90b: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  • 0355888: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak
  • ab81cd0: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
  • 676b097: 8236136: tests which use CompilationMode shouldn't be run w/ TieredStopAtLevel
  • fc81c86: 8285686: Update FreeType to 2.12.0

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2022
@openjdk openjdk bot closed this May 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2022
@openjdk
Copy link

openjdk bot commented May 24, 2022

@AlexanderScherbatiy Pushed as commit fb234ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@AlexanderScherbatiy AlexanderScherbatiy deleted the JDK-8181571 branch May 26, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants