New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8181571: printing to CUPS fails on mac sandbox app #405
8181571: printing to CUPS fails on mac sandbox app #405
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
@AlexanderScherbatiy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Can you please make a dependent pull request for JDK-8285397 so they can be pushed together? Please add the fix-request tag in the JBS issue again after this. Best, Goetz. |
The dependent pull request #409 is created for JDK-8285397. |
/integrate |
Going to push as commit fb234ac.
Your commit was automatically rebased without conflicts. |
@AlexanderScherbatiy Pushed as commit fb234ac. |
This is a clean backport of JDK-8181571 printing to CUPS fails on mac sandbox app.
I manually checked that a signed java application with the fix prints a test page when running within the macOS sandbox.
The tests jdk-tier1, jdk-tier2, jdk-tier3 automated tests have been run on Mac M1.
The only failed test on my system is tools/jlink/JLinkTest.java.JLinkTest which fails without the fix as well.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/405/head:pull/405
$ git checkout pull/405
Update a local copy of the PR:
$ git checkout pull/405
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/405/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 405
View PR using the GUI difftool:
$ git pr show -t 405
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/405.diff