Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8139173: [macosx] JInternalFrame shadow is not properly drawn #408

Closed
wants to merge 1 commit into from

Conversation

takiguc
Copy link

@takiguc takiguc commented May 19, 2022

Backport JDK-8139173

Clean backport


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8139173: [macosx] JInternalFrame shadow is not properly drawn

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/408/head:pull/408
$ git checkout pull/408

Update a local copy of the PR:
$ git checkout pull/408
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/408/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 408

View PR using the GUI difftool:
$ git pr show -t 408

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/408.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2022

👋 Welcome back itakiguchi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f7814c120bf84d7e9b459f81a6ce19b44fa122ec 8139173: [macosx] JInternalFrame shadow is not properly drawn May 19, 2022
@openjdk
Copy link

openjdk bot commented May 19, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 19, 2022

@takiguc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8139173: [macosx] JInternalFrame shadow is not properly drawn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • d70f90b: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  • 0355888: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak
  • ab81cd0: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
  • 676b097: 8236136: tests which use CompilationMode shouldn't be run w/ TieredStopAtLevel

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 19, 2022
@mlbridge
Copy link

mlbridge bot commented May 19, 2022

Webrevs

@takiguc
Copy link
Author

takiguc commented May 23, 2022

jdk17u-fix-yes was verified.

/integrate

@openjdk
Copy link

openjdk bot commented May 23, 2022

Going to push as commit 1fece41.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 817457e: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
  • c94a235: 8209776: Refactor jdk/security/JavaDotSecurity/ifdefs.sh to plain java test
  • d70f90b: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  • 0355888: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak
  • ab81cd0: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
  • 676b097: 8236136: tests which use CompilationMode shouldn't be run w/ TieredStopAtLevel

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2022
@openjdk openjdk bot closed this May 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2022
@openjdk
Copy link

openjdk bot commented May 23, 2022

@takiguc Pushed as commit 1fece41.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant