8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom

[GoeLin]

I backport this for parity with 17.0.18-oracle.

Omitted test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java
That test was added by https://bugs.openjdk.org/browse/JDK-8301154 SunPKCS11 KeyStore deleteEntry results in dangling PrivateKey entries.
Actually a bugfix that sounds desireable for 17, but let"s not deviate from Oracle VM here.

Further same copyright as in 21.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8366159 needs maintainer approval

Issue

• JDK-8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom (Bug - P4 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4123/head:pull/4123
$ git checkout pull/4123

Update a local copy of the PR:
$ git checkout pull/4123
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4123/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4123

View PR using the GUI difftool:
$ git pr show -t 4123

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4123.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 846d334: 8327071: [Testbug] g-tests for cgroup leave files in /tmp on linux
• 424eeab: 8354233: Open some JTable bugs 6
• 5d35f53: 8270083: -Wnonnull errors happen with GCC 11.1.1
• ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/63406ab4693d2b0612583661075a3ccdb14b4bf1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (50bc36e6)

[TheRealMDoerr]

I agree.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 1303000.
Since your change was applied there have been 26 commits pushed to the master branch:

• 5ddafa0: 8358813: JPasswordField identifies spaces in password via delete shortcuts
• b599a56: 8346753: Test javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus LookAndFeel
• c26cf5b: 8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization
• ... and 23 more: https://git.openjdk.org/jdk17u-dev/compare/63406ab4693d2b0612583661075a3ccdb14b4bf1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 1303000.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.