Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287162: (zipfs) Performance regression related to support for POSIX file permissions #417

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 25, 2022

Hi all,

This pull request contains a backport of JDK-8287162, commit a10c5597 from the openjdk/jdk repository.

The commit being backported was authored by Lance Andersen on 24 May 2022 and was reviewed by Jaikiran Pai, Alan Bateman and Christoph Langer.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287162: (zipfs) Performance regression related to support for POSIX file permissions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/417/head:pull/417
$ git checkout pull/417

Update a local copy of the PR:
$ git checkout pull/417
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/417/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 417

View PR using the GUI difftool:
$ git pr show -t 417

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/417.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a10c5597d93c4402bafdbb570437aac052b10027 8287162: (zipfs) Performance regression related to support for POSIX file permissions May 25, 2022
@openjdk
Copy link

openjdk bot commented May 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 25, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287162: (zipfs) Performance regression related to support for POSIX file permissions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2022
@mlbridge
Copy link

mlbridge bot commented May 25, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

closing in favor of openjdk/jdk17u#342

@RealCLanger RealCLanger closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
1 participant