Skip to content

Conversation

@cost0much
Copy link
Contributor

@cost0much cost0much commented Nov 18, 2025

Clean backport. Fixes performance regression of DecimalFormat. Passes GHA.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333462 needs maintainer approval

Issue

  • JDK-8333462: Performance regression of new DecimalFormat() when compare to jdk11 (Bug - P4 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4189/head:pull/4189
$ git checkout pull/4189

Update a local copy of the PR:
$ git checkout pull/4189
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4189

View PR using the GUI difftool:
$ git pr show -t 4189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4189.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2025

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d826127970bd2ae8bf4cacc3c55634dc5af307c4 8333462: Performance regression of new DecimalFormat() when compare to jdk11 Nov 18, 2025
@openjdk
Copy link

openjdk bot commented Nov 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 18, 2025
@cost0much cost0much marked this pull request as ready for review November 20, 2025 23:09
@openjdk
Copy link

openjdk bot commented Nov 20, 2025

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2025

Webrevs

@cost0much
Copy link
Contributor Author

/approval request Fixes a JDK17 performance regression of new DecimalFormat. Already backported to 21.0.5 and applies cleanly from JDK23. Passes GHA. Risk is low as lib change + previous 21 backport has gone multiple releases without issue.

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

@cost0much
8333462: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 20, 2025
@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Nov 28, 2025
@cost0much cost0much closed this Nov 28, 2025
@cost0much cost0much deleted the 8333462 branch November 28, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant