Skip to content

Conversation

@dchuyko
Copy link
Member

@dchuyko dchuyko commented Dec 29, 2021

Small change in G1 with good performance effect. Original patch applies cleanly.

Testing: jtreg tier1 & gc (aarch64 build).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8271579: G1: Move copy before CAS in do_copy_to_survivor_space
  • JDK-8272070: G1: Simplify age calculation after JDK-8271579

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/42/head:pull/42
$ git checkout pull/42

Update a local copy of the PR:
$ git checkout pull/42
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/42/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 42

View PR using the GUI difftool:
$ git pr show -t 42

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/42.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 29, 2021

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d874e9616f80324a53f3c8866ce500e55dfa308f 8271579: G1: Move copy before CAS in do_copy_to_survivor_space Dec 29, 2021
@openjdk
Copy link

openjdk bot commented Dec 29, 2021

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 29, 2021
@openjdk
Copy link

openjdk bot commented Dec 29, 2021

@dchuyko This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271579: G1: Move copy before CAS in do_copy_to_survivor_space
8272070: G1: Simplify age calculation after JDK-8271579

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • f016e60: 8275610: C2: Object field load floats above its null check resulting in a segfault
  • 3adb3dd: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError
  • 38fdf4f: 8276623: JDK-8275650 accidentally pushed "out" file
  • d30b6e4: 8277328: jdk/jshell/CommandCompletionTest.java failures on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 29, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 29, 2021

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2022

@dchuyko This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@dchuyko
Copy link
Member Author

dchuyko commented Feb 10, 2022

No failures in test/hotspot/jtreg/applications/jcstress on Graviton2, 64 cpus.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2022

@dchuyko This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2022

@dchuyko This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant