Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284094: Memory leak in invoker_completeInvokeRequest() #422

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented May 29, 2022

Hi all,

This pull request contains a backport of commit 1dfa1eae from the openjdk/jdk repository.

The commit being backported was authored by Roman Kennke on 1 Apr 2022 and was reviewed by Chris Plummer and Aleksey Shipilev.

This fixes a memory leak in the JDWP agent. It has baked in trunk for over a month and should now be safe enough to backport to stable releases.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284094: Memory leak in invoker_completeInvokeRequest()

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/422/head:pull/422
$ git checkout pull/422

Update a local copy of the PR:
$ git checkout pull/422
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/422/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 422

View PR using the GUI difftool:
$ git pr show -t 422

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/422.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 29, 2022

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1dfa1eaea0c8958f4b793c0766e36607cbde5c7f 8284094: Memory leak in invoker_completeInvokeRequest() May 29, 2022
@openjdk
Copy link

openjdk bot commented May 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 29, 2022

@gnu-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284094: Memory leak in invoker_completeInvokeRequest()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 29, 2022
@mlbridge
Copy link

mlbridge bot commented May 29, 2022

Webrevs

@gnu-andrew
Copy link
Member Author

Backport is clean and I see jdk17u-fix-yes

@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 31, 2022

Going to push as commit 9439a87.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 3e42e25: 8284437: Building from different users/workspace is not always deterministic
  • 4330e5f: 8287362: FieldAccessWatch testcase failed on AIX platform
  • b9841d4: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale
  • 18d3e4d: 8287336: GHA: Workflows break on patch versions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2022
@openjdk openjdk bot closed this May 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2022
@openjdk
Copy link

openjdk bot commented May 31, 2022

@gnu-andrew Pushed as commit 9439a87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant