Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class #430

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 3, 2022

Hi all,
This pull request contains a backport of commit 40f19c01 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 29 Apr 2022 and was reviewed by Phil Race.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/430/head:pull/430
$ git checkout pull/430

Update a local copy of the PR:
$ git checkout pull/430
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/430/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 430

View PR using the GUI difftool:
$ git pr show -t 430

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/430.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 40f19c014fed37b09db409cb9507f68f5011f139 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class Jun 3, 2022
@openjdk
Copy link

openjdk bot commented Jun 3, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 3, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 3, 2022
@mrserb mrserb marked this pull request as ready for review June 5, 2022 21:41
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 5, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jun 7, 2022

Hi, what is wrong with the Pre-submit tests?

@mrserb
Copy link
Member Author

mrserb commented Jun 9, 2022

There are two failures in javac:

tools/javac/Paths/MineField.sh 
tools/javac/Paths/wcMineField.sh

https://bugs.openjdk.org/browse/JDK-8287378

@mrserb
Copy link
Member Author

mrserb commented Jun 9, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 9, 2022

Going to push as commit 3ef9ce6.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 9, 2022
@openjdk openjdk bot closed this Jun 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@mrserb Pushed as commit 3ef9ce6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants