Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8225122: Test AncestorResized.java fails when Windows desktop is scaled. #431

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 4, 2022

Hi all,
This pull request contains a backport of commit 77757ba9 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 8 Jan 2022 and was reviewed by Alexander Zuev and Alexey Ivanov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8225122: Test AncestorResized.java fails when Windows desktop is scaled.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/431/head:pull/431
$ git checkout pull/431

Update a local copy of the PR:
$ git checkout pull/431
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/431/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 431

View PR using the GUI difftool:
$ git pr show -t 431

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/431.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 77757ba974239b558e29c7adc551dfa04b9baa48 8225122: Test AncestorResized.java fails when Windows desktop is scaled. Jun 4, 2022
@openjdk
Copy link

openjdk bot commented Jun 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 4, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225122: Test AncestorResized.java fails when Windows desktop is scaled.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 4, 2022
@mrserb mrserb marked this pull request as ready for review June 5, 2022 20:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 5, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Jun 8, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 8, 2022

Going to push as commit 4e45ac9.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 551b027: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950
  • 9a4f12d: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
  • d16d4f1: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound
  • 3013100: 8283597: [REDO] Invalid generic signature for redefined classes
  • 9c9c061: 8282214: Upgrade JQuery to version 3.6.0
  • c2d2dc7: 8281628: KeyAgreement : generateSecret intermittently not resetting
  • 2903d59: 8282467: add extra diagnostics for JDK-8268184
  • 4b1bba8: Merge
  • 3472ab2: 8286855: javac error on invalid jar should only print filename
  • 6ed9725: 8287162: (zipfs) Performance regression related to support for POSIX file permissions
  • ... and 5 more: https://git.openjdk.java.net/jdk17u-dev/compare/629754e743822e1ef03da21a3e0a0f86e238cd4d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 8, 2022
@openjdk openjdk bot closed this Jun 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 8, 2022
@openjdk
Copy link

openjdk bot commented Jun 8, 2022

@mrserb Pushed as commit 4e45ac9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant