Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Jun 6, 2022

Hi all,
This pull request contains a backport of commit 645be42f from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 6 Jun 2022 and was reviewed by Iris Clark and Phil Race.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287824: The MTPerLineTransformValidation tests has a typo in the @run tag

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/432/head:pull/432
$ git checkout pull/432

Update a local copy of the PR:
$ git checkout pull/432
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/432/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 432

View PR using the GUI difftool:
$ git pr show -t 432

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/432.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 645be42f76b8983a9096ed90caa70b5c59dd822c 8287824: The MTPerLineTransformValidation tests has a typo in the @run tag Jun 6, 2022
@openjdk
Copy link

openjdk bot commented Jun 6, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 6, 2022
@openjdk
Copy link

openjdk bot commented Jun 6, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287824: The MTPerLineTransformValidation tests has a typo in the @run tag

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 6, 2022
@mrserb mrserb marked this pull request as ready for review June 7, 2022 00:20
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Jun 8, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 8, 2022

Going to push as commit e7a37b6.
Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 8, 2022
@openjdk openjdk bot closed this Jun 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 8, 2022
@openjdk
Copy link

openjdk bot commented Jun 8, 2022

@mrserb Pushed as commit e7a37b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant