Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285820: C2: LCM prioritizes locally dependent CreateEx nodes over projections after 8270090 #442

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 8, 2022

I backport this for parity with 17.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285820: C2: LCM prioritizes locally dependent CreateEx nodes over projections after 8270090

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/442/head:pull/442
$ git checkout pull/442

Update a local copy of the PR:
$ git checkout pull/442
$ git pull https://git.openjdk.org/jdk17u-dev pull/442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 442

View PR using the GUI difftool:
$ git pr show -t 442

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/442.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 8, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/441 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8ebea443f333ecf79d6b0fc725ededb231e83ed5 8270090: C2: LCM may prioritize CheckCastPP nodes over projections Jun 8, 2022
@openjdk
Copy link

openjdk bot commented Jun 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Jun 8, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 8, 2022

Webrevs

@GoeLin GoeLin changed the title 8270090: C2: LCM may prioritize CheckCastPP nodes over projections Backport 89392fb15e9652b7b562b3511f79bda725c5499c Jun 8, 2022
@openjdk openjdk bot changed the title Backport 89392fb15e9652b7b562b3511f79bda725c5499c 8285820: C2: LCM prioritizes locally dependent CreateEx nodes over projections after 8270090 Jun 8, 2022
@openjdk
Copy link

openjdk bot commented Jun 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the clean label Jun 8, 2022
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/441 to master Jun 10, 2022
@openjdk-notifier
Copy link

openjdk-notifier bot commented Jun 10, 2022

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8285820
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Jun 10, 2022
@openjdk openjdk bot added the clean label Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285820: C2: LCM prioritizes locally dependent CreateEx nodes over projections after 8270090

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 10, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 10, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

Going to push as commit 667582d.

@openjdk openjdk bot added the integrated label Jun 10, 2022
@openjdk openjdk bot closed this Jun 10, 2022
@openjdk openjdk bot removed ready rfr labels Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@GoeLin Pushed as commit 667582d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8285820 branch Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant