Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284694: Avoid evaluating SSLAlgorithmConstraints twice #446

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 8, 2022

I backport this for parity with 17.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284694: Avoid evaluating SSLAlgorithmConstraints twice

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/446/head:pull/446
$ git checkout pull/446

Update a local copy of the PR:
$ git checkout pull/446
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/446/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 446

View PR using the GUI difftool:
$ git pr show -t 446

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/446.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 8, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d8446b4f60472b11e4cdaef97288fe143cca4511 8284694: Avoid evaluating SSLAlgorithmConstraints twice Jun 8, 2022
@openjdk
Copy link

openjdk bot commented Jun 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 8, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284694: Avoid evaluating SSLAlgorithmConstraints twice

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3013100: 8283597: [REDO] Invalid generic signature for redefined classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jun 8, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 8, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 10, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

Going to push as commit 66cdd6e.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 92d617f: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java
  • 667582d: 8285820: C2: LCM prioritizes locally dependent CreateEx nodes over projections after 8270090
  • 2da3752: 8270090: C2: LCM may prioritize CheckCastPP nodes over projections
  • 7023eef: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete
  • 0d0e4fb: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller
  • 3ef9ce6: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class
  • e7a37b6: 8287824: The MTPerLineTransformValidation tests has a typo in the @run tag
  • 4e45ac9: 8225122: Test AncestorResized.java fails when Windows desktop is scaled.
  • 551b027: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950
  • 9a4f12d: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/9c9c061a5001d27668b7261199a188b0d756be5b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jun 10, 2022
@openjdk openjdk bot closed this Jun 10, 2022
@openjdk openjdk bot removed ready rfr labels Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@GoeLin Pushed as commit 66cdd6e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant