Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8155701: The compiler fails with an AssertionError: typeSig ERROR #453

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 9, 2022

I backport this for parity with 17.0.5-oracle.


Progress

  • JDK-8155701 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8155701: The compiler fails with an AssertionError: typeSig ERROR (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/453/head:pull/453
$ git checkout pull/453

Update a local copy of the PR:
$ git checkout pull/453
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 453

View PR using the GUI difftool:
$ git pr show -t 453

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/453.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1e28fcbc5f32103f460bc35235b3cad0cfaa69b5 8155701: The compiler fails with an AssertionError: typeSig ERROR Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@GoeLin This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 9, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2022

@GoeLin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2022

@GoeLin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Aug 4, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Oct 24, 2023

/open

@openjdk openjdk bot reopened this Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@GoeLin This pull request is now open

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 24, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 25, 2023

Test fails

@GoeLin GoeLin closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
1 participant