Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287073: NPE from CgroupV2Subsystem.getInstance() #456

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jun 9, 2022

Clean backport. Issue present in 17u too and low risk fix. Regression test in JDK-8287663 which I intend to backport too.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287073: NPE from CgroupV2Subsystem.getInstance()

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/456/head:pull/456
$ git checkout pull/456

Update a local copy of the PR:
$ git checkout pull/456
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/456/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 456

View PR using the GUI difftool:
$ git pr show -t 456

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/456.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 744b822ab194a0f7ef4e7a4053be32c6a0889efc 8287073: NPE from CgroupV2Subsystem.getInstance() Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287073: NPE from CgroupV2Subsystem.getInstance()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 9, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2022

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Jun 13, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 13, 2022

Going to push as commit cb88133.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 292d90d: 8178969: [TESTBUG] Wrong reporting of gc/g1/humongousObjects/TestHeapCounters test.
  • a081e4a: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
  • aa3d2f7: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • 66cdd6e: 8284694: Avoid evaluating SSLAlgorithmConstraints twice
  • 92d617f: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java
  • 667582d: 8285820: C2: LCM prioritizes locally dependent CreateEx nodes over projections after 8270090
  • 2da3752: 8270090: C2: LCM may prioritize CheckCastPP nodes over projections

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2022
@openjdk openjdk bot closed this Jun 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2022
@openjdk
Copy link

openjdk bot commented Jun 13, 2022

@jerboaa Pushed as commit cb88133.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant