Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287663: Add a regression test for JDK-8287073 #457

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jun 9, 2022

Clean backport. Follow-up for JDK-8287073. Test fails prior code change from JDK-8287073 and passes after.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/457/head:pull/457
$ git checkout pull/457

Update a local copy of the PR:
$ git checkout pull/457
$ git pull https://git.openjdk.org/jdk17u-dev pull/457/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 457

View PR using the GUI difftool:
$ git pr show -t 457

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/457.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/456 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2d8c6490540e3ccea23b81129b2e4073915071e0 8287663: Add a regression test for JDK-8287073 Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 9, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2022

Webrevs

@jerboaa jerboaa force-pushed the jdk-8287663-add-regtest-backport branch from 7c07274 to 095bb56 Compare June 13, 2022 14:18
@openjdk-notifier
Copy link

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@jerboaa jerboaa changed the base branch from pr/456 to master June 13, 2022 14:23
@openjdk
Copy link

openjdk bot commented Jun 13, 2022

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287663: Add a regression test for JDK-8287073

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 13, 2022
@jerboaa
Copy link
Contributor Author

jerboaa commented Jun 13, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 13, 2022

Going to push as commit 8563eec.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2022
@openjdk openjdk bot closed this Jun 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2022
@openjdk
Copy link

openjdk bot commented Jun 13, 2022

@jerboaa Pushed as commit 8563eec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant