Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false] #460

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 10, 2022

I backport this to fix failures in the Pre-submit tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/460/head:pull/460
$ git checkout pull/460

Update a local copy of the PR:
$ git checkout pull/460
$ git pull https://git.openjdk.org/jdk17u-dev pull/460/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 460

View PR using the GUI difftool:
$ git pr show -t 460

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/460.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 97a983526b41d26fcd1caa162a089690119874b0 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false] Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 10, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 14, 2022

Going to push as commit dd7280f.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 1963985: 8283849: AsyncGetCallTrace may crash JVM on guarantee
  • 8563eec: 8287663: Add a regression test for JDK-8287073
  • cb88133: 8287073: NPE from CgroupV2Subsystem.getInstance()
  • 292d90d: 8178969: [TESTBUG] Wrong reporting of gc/g1/humongousObjects/TestHeapCounters test.
  • a081e4a: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
  • aa3d2f7: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • 66cdd6e: 8284694: Avoid evaluating SSLAlgorithmConstraints twice
  • 92d617f: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java
  • 667582d: 8285820: C2: LCM prioritizes locally dependent CreateEx nodes over projections after 8270090
  • 2da3752: 8270090: C2: LCM may prioritize CheckCastPP nodes over projections

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 14, 2022
@openjdk openjdk bot closed this Jun 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 14, 2022
@openjdk
Copy link

openjdk bot commented Jun 14, 2022

@GoeLin Pushed as commit dd7280f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant