Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null #462

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 13, 2022

I backport this for parity with 17.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/462/head:pull/462
$ git checkout pull/462

Update a local copy of the PR:
$ git checkout pull/462
$ git pull https://git.openjdk.org/jdk17u-dev pull/462/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 462

View PR using the GUI difftool:
$ git pr show -t 462

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/462.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/450 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 47951655acacba515c0d69f5192257664f887dba 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null Jun 13, 2022
@openjdk
Copy link

openjdk bot commented Jun 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 13, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 13, 2022

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/450 to master June 21, 2022 12:42
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8285696
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Jun 21, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 21, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@GoeLin This pull request has not yet been marked as ready for integration.

@GoeLin
Copy link
Member Author

GoeLin commented Jun 21, 2022

/clean

@openjdk openjdk bot added the clean label Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg'  is null

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 21, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

Going to push as commit 6f4c270.
Since your change was applied there have been 29 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 21, 2022
@openjdk openjdk bot closed this Jun 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@GoeLin Pushed as commit 6f4c270.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8285696 branch June 21, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant