Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform) #47

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 29, 2021

Hi all,
This pull request contains a backport of commit e49e5b5a from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 28 Sep 2021 and was reviewed by Phil Race.

See more details here

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/47/head:pull/47
$ git checkout pull/47

Update a local copy of the PR:
$ git checkout pull/47
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/47/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 47

View PR using the GUI difftool:
$ git pr show -t 47

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/47.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 29, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e49e5b5a7ed9e493380fb73100057898c707b31b 8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform) Dec 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 29, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • dcd9821: 8272167: AbsPathsInImage.java should skip *.dSYM directories
  • 493a78a: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor
  • f016e60: 8275610: C2: Object field load floats above its null check resulting in a segfault
  • 3adb3dd: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError
  • 38fdf4f: 8276623: JDK-8275650 accidentally pushed "out" file
  • d30b6e4: 8277328: jdk/jshell/CommandCompletionTest.java failures on Windows
  • 6aa60ac: 8277441: CompileQueue::add fails with assert(_last->next() == __null) failed: not last
  • 15f2406: 8274714: Incorrect verifier protected access error message
  • 4a38659: 8274658: ISO 4217 Amendment 170 Update
  • 5287dae: 8274795: AArch64: avoid spilling and restoring r18 in macro assembler

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 29, 2021
@mrserb mrserb marked this pull request as ready for review Dec 30, 2021
@openjdk openjdk bot added the rfr label Dec 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 30, 2021

Webrevs

@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 21, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2022

Going to push as commit 55fb592.
Since your change was applied there have been 137 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 21, 2022
@openjdk openjdk bot closed this Jan 21, 2022
@openjdk openjdk bot removed ready rfr labels Jan 21, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2022

@mrserb Pushed as commit 55fb592.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant