Skip to content

8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 20, 2022

Hi all,
This pull request contains a backport of commit ebfa27b9 from the openjdk/jdk repository.
The commit being backported was authored by Alexander Zuev on 25 May 2022 and was reviewed by Sergey Bylokhov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/480/head:pull/480
$ git checkout pull/480

Update a local copy of the PR:
$ git checkout pull/480
$ git pull https://git.openjdk.org/jdk17u-dev pull/480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 480

View PR using the GUI difftool:
$ git pr show -t 480

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/480.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ebfa27b9f06aee8ceceabc564a78a351903ce9a1 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox Jun 20, 2022
@openjdk
Copy link

openjdk bot commented Jun 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 20, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 297 new commits pushed to the master branch:

  • 6624f71: 8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle
  • ce949ba: 8276904: Optional.toString() is unnecessarily expensive
  • ca8e16d: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • 0657a3a: 8280511: AArch64: Combine shift and negate to a single instruction
  • 2d4fec4: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 13ecd42: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
  • 3d93fdc: 8294357: (tz) Update Timezone Data to 2022d
  • 29fea3f: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
  • 673b505: 8293816: CI: ciBytecodeStream::get_klass() is not consistent
  • 6882bd3: 8293044: C1: Missing access check on non-accessible class
  • ... and 287 more: https://git.openjdk.org/jdk17u-dev/compare/f0dd3223100fb6da3c5425b87098a7d1c5cd2698...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 20, 2022
@mrserb mrserb marked this pull request as ready for review June 20, 2022 21:04
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 20, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2022

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2022

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Aug 16, 2022
@mrserb
Copy link
Member Author

mrserb commented Oct 10, 2022

/open

@openjdk openjdk bot reopened this Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@mrserb This pull request is now open

@GoeLin
Copy link
Member

GoeLin commented Oct 10, 2022

Hi @mrserb, hod did you test this and the 11u backport? Best, Goetz.

@mrserb
Copy link
Member Author

mrserb commented Oct 11, 2022

@GoeLin
I have verified the fix manually using the steps in the bug report and have run the jdk_desktop tests, no new issues were found.

@mrserb
Copy link
Member Author

mrserb commented Oct 24, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 24, 2022

Going to push as commit 525b9fc.
Since your change was applied there have been 346 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2022
@openjdk openjdk bot closed this Oct 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2022
@openjdk
Copy link

openjdk bot commented Oct 24, 2022

@mrserb Pushed as commit 525b9fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants