Skip to content

8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc#485

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:GoeLin-backport-4a5e7a1a
Closed

8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc#485
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:GoeLin-backport-4a5e7a1a

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 21, 2022

I backport this for parity with 17.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/485/head:pull/485
$ git checkout pull/485

Update a local copy of the PR:
$ git checkout pull/485
$ git pull https://git.openjdk.org/jdk17u-dev pull/485/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 485

View PR using the GUI difftool:
$ git pr show -t 485

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/485.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4a5e7a1ada611cfdefdc3b9a6fada05494e07390 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 1584ddc: 8282778: Create a regression test for JDK-4699544
  • 4d92532: 8285380: Fix typos in security

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 22, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 22, 2022

Going to push as commit b91c492.
Since your change was applied there have been 7 commits pushed to the master branch:

  • e0750eb: 8265360: several compiler/whitebox tests fail with "private compiler.whitebox.SimpleTestCaseHelper(int) must be compiled"
  • 9f57018: 8274597: Some of the dnd tests time out and fail intermittently
  • d798aa2: 8284521: Write an automated regression test for RFE 4371575
  • 3b8f43e: 8282046: Create a regression test for JDK-8000326
  • f5e1c3f: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails
  • 1584ddc: 8282778: Create a regression test for JDK-4699544
  • 4d92532: 8285380: Fix typos in security

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 22, 2022
@openjdk openjdk bot closed this Jun 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2022
@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@GoeLin Pushed as commit b91c492.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant