Skip to content

8286582: Build fails on macos aarch64 when using --with-zlib=bundled #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 22, 2022

Hi all,
This pull request contains a backport of commit 50d47de8 from the openjdk/jdk repository.
The commit being backported was authored by Jaikiran Pai on 12 May 2022 and was reviewed by Magnus Ihse Bursie and Lance Andersen.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286582: Build fails on macos aarch64 when using --with-zlib=bundled

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/493/head:pull/493
$ git checkout pull/493

Update a local copy of the PR:
$ git checkout pull/493
$ git pull https://git.openjdk.org/jdk17u-dev pull/493/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 493

View PR using the GUI difftool:
$ git pr show -t 493

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/493.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into pr/492 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 50d47de8358e2f22bf3a4a165d660c25ef6eacbc 8286582: Build fails on macos aarch64 when using --with-zlib=bundled Jun 22, 2022
@openjdk
Copy link

openjdk bot commented Jun 22, 2022

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review June 22, 2022 06:12
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 22, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2022

Webrevs

@AlanBateman
Copy link
Contributor

Have you had any contact with Apple on this issue? I think it would be useful to get an update on the bug.

@mrserb
Copy link
Member Author

mrserb commented Jun 22, 2022

Have you had any contact with Apple on this issue? I think it would be useful to get an update on the bug.

This bug is about "--with-zlib" option and the possibility to use/compile the "bundled" version of the zlib on macOS, it does not switch the zlib from the "system" one. I did not make a decision(yet) on what version of the zlib should be used by default, but it would be good to have a possiblities to switch one to another,

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/492 to master June 23, 2022 02:08
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout mrserb-backport-50d47de8
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Jun 23, 2022
@openjdk openjdk bot added the clean label Jun 23, 2022
@openjdk
Copy link

openjdk bot commented Jun 23, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286582: Build fails on macos aarch64 when using --with-zlib=bundled

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 23, 2022
@mrserb
Copy link
Member Author

mrserb commented Jun 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2022

Going to push as commit 6f0f842.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 68456bb: 8288754: GCC 12 fails to build zReferenceProcessor.cpp
  • 72603ff: 8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2022
@openjdk openjdk bot closed this Jun 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2022
@openjdk
Copy link

openjdk bot commented Jun 23, 2022

@mrserb Pushed as commit 6f0f842.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants