-
Notifications
You must be signed in to change notification settings - Fork 224
8286582: Build fails on macos aarch64 when using --with-zlib=bundled #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
Have you had any contact with Apple on this issue? I think it would be useful to get an update on the bug. |
This bug is about "--with-zlib" option and the possibility to use/compile the "bundled" version of the zlib on macOS, it does not switch the zlib from the "system" one. I did not make a decision(yet) on what version of the zlib should be used by default, but it would be good to have a possiblities to switch one to another, |
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout mrserb-backport-50d47de8
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 6f0f842.
Your commit was automatically rebased without conflicts. |
Hi all,
This pull request contains a backport of commit 50d47de8 from the openjdk/jdk repository.
The commit being backported was authored by Jaikiran Pai on 12 May 2022 and was reviewed by Magnus Ihse Bursie and Lance Andersen.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/493/head:pull/493
$ git checkout pull/493
Update a local copy of the PR:
$ git checkout pull/493
$ git pull https://git.openjdk.org/jdk17u-dev pull/493/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 493
View PR using the GUI difftool:
$ git pr show -t 493
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/493.diff