Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279622: C2: miscompilation of map pattern as a vector reduction #494

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 22, 2022

I backport this for parity with 17.0.5-oracle.

I had to resolve superword.cpp.
Only adding an assertions there, context differs.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279622: C2: miscompilation of map pattern as a vector reduction

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/494/head:pull/494
$ git checkout pull/494

Update a local copy of the PR:
$ git checkout pull/494
$ git pull https://git.openjdk.org/jdk17u-dev pull/494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 494

View PR using the GUI difftool:
$ git pr show -t 494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/494.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6fcd322258e0cce3724a4a8dc18f7802018a7cc9 8279622: C2: miscompilation of map pattern as a vector reduction Jun 22, 2022
@openjdk
Copy link

openjdk bot commented Jun 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279622: C2: miscompilation of map pattern as a vector reduction

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 1584ddc: 8282778: Create a regression test for JDK-4699544
  • 4d92532: 8285380: Fix typos in security
  • f1d3fa9: 8287113: JFR: Periodic task thread uses period for method sampling events

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 24, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 24, 2022

Going to push as commit 47e478d.
Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2022
@openjdk openjdk bot closed this Jun 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2022
@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@GoeLin Pushed as commit 47e478d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8279622 branch June 24, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant