8256844: Make NMT late-initializable

[VladimirKempik]

Please review this backport to jdk17u-dev
Doesn't apply clean because of JDK-8280940 backport which introduced the same patch into test_os.cpp

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8256844: Make NMT late-initializable

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/496/head:pull/496
$ git checkout pull/496

Update a local copy of the PR:
$ git checkout pull/496
$ git pull https://git.openjdk.org/jdk17u-dev pull/496/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 496

View PR using the GUI difftool:
$ git pr show -t 496

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/496.diff

[bridgekeeper]

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (92b8e3a0)

[tstuefe]

I'm all for this and had planned to do this sometime this year, but please be aware that this is a bit larger and needs to be tested thoroughly. So far it has seen the light of customer machines only for JDK18, so probably not too much exposure there.

At the very least we should and will cook this patch for a week or two in our JDk17 CI. Would be nice if you could schedule some tests too.

Cheers, Thomas

[tstuefe]

BTW getting NMT to run under IntelliJ was one of the reasons for this patch :)

[VladimirKempik]

BTW getting NMT to run under IntelliJ was one of the reasons for this patch :)

That is my main objective, Since idea 2022.2 is migrating to jdk17.

[tstuefe]

Test changes are okay.

I'd like to see some mass tests running though, for some days maybe. I'm worried about the changed pre-init allocation mechanics. This patch has been well tested in 18 and beyond, so I may just be paranoid. Just worry about aspects I did not think to test, like native integration.

One small concern I have is that with this patch, we stop recognizing the old NMT_LEVEL_<pid> variable. This needs a patch note somewhere (no clue where, @GoeLin ?).

[openjdk]

@VladimirKempik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256844: Make NMT late-initializable

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• a411085: 8285081: Improve XPath operators count accuracy
• 4403118: 8286211: Update PCSC-Lite for Suse Linux to 1.9.5
• b7d808e: 8284367: JQuery UI upgrade from 1.12.1 to 1.13.1
• c1e544f: 8286638: C2: CmpU needs to do more precise over/underflow analysis
• b91c492: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc
• e0750eb: 8265360: several compiler/whitebox tests fail with "private compiler.whitebox.SimpleTestCaseHelper(int) must be compiled"
• 9f57018: 8274597: Some of the dnd tests time out and fail intermittently
• d798aa2: 8284521: Write an automated regression test for RFE 4371575
• 3b8f43e: 8282046: Create a regression test for JDK-8000326
• f5e1c3f: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[VladimirKempik]

Github CI testing is ok

[tstuefe]

Testing showed no problems for several days. Good from my end.

[VladimirKempik]

I'll wait a bit more for tests to complete in JB env.

[VladimirKempik]

Tests look good in JB infra too

[VladimirKempik]

/integrate

[openjdk]

Going to push as commit 774213f.
Since your change was applied there have been 35 commits pushed to the master branch:

• 437c634: 8281181: Do not use CPU Shares to compute active processor count
• 180f3d9: 8284944: assert(cnt++ < 40) failed: infinite cycle in loop optimization
• 23fc860: 8284294: Create an automated regression test for RFE 4138746
• b0af5e5: 8282936: Write a regression test for JDK-4615365
• 4c96224: 8288467: remove memory_operand assert for spilled instructions
• 201dad4: 8287396: LIR_Opr::vreg_number() and data() can return negative number
• f044785: 8284680: sun.font.FontConfigManager.getFontConfig() leaks charset
• 1675370: 8284956: Potential leak awtImageData/color_data when initializes X11GraphicsEnvironment
• 0ea78e5: 8289197: [17u] Push of backport of 8286177 did not remove assertion
• bbe8c34: 8287366: Improve test failure reporting in GHA
• ... and 25 more: https://git.openjdk.org/jdk17u-dev/compare/1584ddc8975ab33f2f67a5fc1dca2bd82f666f83...master

Your commit was automatically rebased without conflicts.

[openjdk]

@VladimirKempik Pushed as commit 774213f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.