Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic #500

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 22, 2022

Clean backport to fix the C1 intrinsic.

Additional testing:

  • Linux x86_32 fastdebug, JFR reproducer does not hang anymore
  • Linux x86_32 fastdebug, new test passes
  • Linux x86_64 fastdebug, new test passes
  • Linux x86_32 fastdebug, tier1 passes
  • Linux x86_64 fastdebug, tier1 passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/500/head:pull/500
$ git checkout pull/500

Update a local copy of the PR:
$ git checkout pull/500
$ git pull https://git.openjdk.org/jdk17u-dev pull/500/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 500

View PR using the GUI difftool:
$ git pr show -t 500

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/500.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8cd87e731bcaff2d7838995c68056742d577ad3b 8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic Jun 22, 2022
@openjdk
Copy link

openjdk bot commented Jun 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jun 23, 2022

Hi,
what are the strange Pre-submit failures on windows in tools/javac/Paths/MineField.sh?
I would assume they are unrelated, but I have not seen this before.

@shipilev
Copy link
Member Author

shipilev commented Jun 23, 2022

Hi, what are the strange Pre-submit failures on windows in tools/javac/Paths/MineField.sh? I would assume they are unrelated, but I have not seen this before.

Hm. I think my PR base was too old, which did not include https://bugs.openjdk.org/browse/JDK-8287378. Merged from current master, let's see what it does for GHA.

@shipilev
Copy link
Member Author

Testing is now clean.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2022

Going to push as commit 72603ff.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2022
@openjdk openjdk bot closed this Jun 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2022
@openjdk
Copy link

openjdk bot commented Jun 23, 2022

@shipilev Pushed as commit 72603ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8288303-c1-miscompile branch October 20, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants