8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic

[shipilev]

Clean backport to fix the C1 intrinsic.

Additional testing:

• Linux x86_32 fastdebug, JFR reproducer does not hang anymore
• Linux x86_32 fastdebug, new test passes
• Linux x86_64 fastdebug, new test passes
• Linux x86_32 fastdebug, tier1 passes
• Linux x86_64 fastdebug, tier1 passes

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/500/head:pull/500
$ git checkout pull/500

Update a local copy of the PR:
$ git checkout pull/500
$ git pull https://git.openjdk.org/jdk17u-dev pull/500/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 500

View PR using the GUI difftool:
$ git pr show -t 500

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/500.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (b5c6b9fa)
• 00: Full (d32dc130)

[GoeLin]

Hi,
what are the strange Pre-submit failures on windows in tools/javac/Paths/MineField.sh?
I would assume they are unrelated, but I have not seen this before.

[shipilev]

Hi, what are the strange Pre-submit failures on windows in tools/javac/Paths/MineField.sh? I would assume they are unrelated, but I have not seen this before.

Hm. I think my PR base was too old, which did not include https://bugs.openjdk.org/browse/JDK-8287378. Merged from current master, let's see what it does for GHA.

[shipilev]

Testing is now clean.

/integrate

[openjdk]

Going to push as commit 72603ff.

[openjdk]

@shipilev Pushed as commit 72603ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.