Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287396: LIR_Opr::vreg_number() and data() can return negative number #502

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 23, 2022

I backport this for parity with 17.0.5-oracle.

I had to do two simple resolves.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287396: LIR_Opr::vreg_number() and data() can return negative number

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/502/head:pull/502
$ git checkout pull/502

Update a local copy of the PR:
$ git checkout pull/502
$ git pull https://git.openjdk.org/jdk17u-dev pull/502/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 502

View PR using the GUI difftool:
$ git pr show -t 502

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/502.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cdb476888a65b8ee2538f08b4b1dbb245874a262 8287396: LIR_Opr::vreg_number() and data() can return negative number Jun 23, 2022
@openjdk
Copy link

openjdk bot commented Jun 23, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 23, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2022

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If using C++11 in 17u is fine, this change is fine

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287396: LIR_Opr::vreg_number() and data() can return negative number

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 0ea78e5: 8289197: [17u] Push of backport of 8286177 did not remove assertion
  • bbe8c34: 8287366: Improve test failure reporting in GHA
  • 42e3184: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run
  • 831b3b8: 8287223: C1: Inlining attempt through MH::invokeBasic() with null receiver
  • 25059b2: 8271078: jdk/incubator/vector/Float128VectorTests.java failed a subtest
  • 1ae5ba5: 8285923: [REDO] JDK-8285802 AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
  • 2e2e891: 8287091: aarch64 : guarantee(val < (1ULL << nbits)) failed: Field too big for insn
  • caceaba: 8286177: C2: "failed: non-reduction loop contains reduction nodes" assert failure
  • dd7ab3d: 8280696: C2 compilation hits assert(is_dominator(c, n_ctrl)) failed
  • 3269cec: 8286870: Memory leak with RepeatCompilation
  • ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/a2be28daca7b67635d0d1ddac770c8b7b8309529...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 27, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 27, 2022

Yes, C++11 is used in 17. Thanks for the review.

@GoeLin
Copy link
Member Author

GoeLin commented Jun 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 29, 2022

Going to push as commit 201dad4.
Since your change was applied there have been 18 commits pushed to the master branch:

  • f044785: 8284680: sun.font.FontConfigManager.getFontConfig() leaks charset
  • 1675370: 8284956: Potential leak awtImageData/color_data when initializes X11GraphicsEnvironment
  • 0ea78e5: 8289197: [17u] Push of backport of 8286177 did not remove assertion
  • bbe8c34: 8287366: Improve test failure reporting in GHA
  • 42e3184: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run
  • 831b3b8: 8287223: C1: Inlining attempt through MH::invokeBasic() with null receiver
  • 25059b2: 8271078: jdk/incubator/vector/Float128VectorTests.java failed a subtest
  • 1ae5ba5: 8285923: [REDO] JDK-8285802 AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
  • 2e2e891: 8287091: aarch64 : guarantee(val < (1ULL << nbits)) failed: Field too big for insn
  • caceaba: 8286177: C2: "failed: non-reduction loop contains reduction nodes" assert failure
  • ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/a2be28daca7b67635d0d1ddac770c8b7b8309529...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 29, 2022
@openjdk openjdk bot closed this Jun 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 29, 2022
@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@GoeLin Pushed as commit 201dad4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8287396 branch June 29, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants