8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier

[jmtd]

Hi all,

This pull request contains a backport of commit fe807217 from the openjdk/jdk repository.

The commit being backported was authored by Yoshiki Sato on 15 Jun 2022 and was reviewed by Mandy Chung.

It applies cleanly to current jdk17u-dev head. The test it modifies passes after the patch.

Running the test was a little unusual. I needed to build the native component by hand and explicitly pass an argument to jtreg:

 $  pushd test/jdk/java/lang/RuntimeTests/loadLibrary/exeLibraryCache
 $  cc  exeLibraryCache.c -o LibraryCache
 $  popd
 $  $JT_HOME/bin/jtreg -jdk:build/macosx-x86_64-server-release/images/jdk  \
 -nativepath:test/jdk/java/lang/RuntimeTests/loadLibrary/exeLibraryCache  \
test/jdk/java/lang/RuntimeTests/loadLibrary/exeLibraryCache/LibraryFromCache.java

test system is macOS Big Sur (11.5.2) with local SDK version 10.14.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/506/head:pull/506
$ git checkout pull/506

Update a local copy of the PR:
$ git checkout pull/506
$ git pull https://git.openjdk.org/jdk17u-dev pull/506/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 506

View PR using the GUI difftool:
$ git pr show -t 506

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/506.diff

[bridgekeeper]

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@jmtd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 0ea78e5: 8289197: [17u] Push of backport of 8286177 did not remove assertion
• bbe8c34: 8287366: Improve test failure reporting in GHA

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (be2fbbd0)

[GoeLin]

Pre-submit failure: unrelated. See 8289197
mac: Exception: Agent 4 timed out ... also unrelated i guess?

[jmtd]

/integrate

mac: Exception: Agent 4 timed out ... also unrelated i guess?

Where can I find that, please?

Pre-submit failure: unrelated. See 8289197

I went ahead and checked these two failing tests locally, just in case, and they pass:

• compiler/loopopts/superword/TestHoistedReductionNode.java
• java/util/concurrent/ConcurrentHashMap/ToArray.java

[openjdk]

@jmtd
Your change (at version be2fbbd) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 7aeba37.
Since your change was applied there have been 15 commits pushed to the master branch:

• a6c02bd: 8288360: CI: ciInstanceKlass::implementor() is not consistent for well-known classes
• d3354af: 8287432: C2: assert(tn->in(0) != __null) failed: must have live top node
• f73037d: 8286625: C2 fails with assert(!n->is_Store() && !n->is_LoadStore()) failed: no node with a side effect
• 7f40f16: 8278067: Make HttpURLConnection default keep alive timeout configurable
• 774213f: 8256844: Make NMT late-initializable
• 437c634: 8281181: Do not use CPU Shares to compute active processor count
• 180f3d9: 8284944: assert(cnt++ < 40) failed: infinite cycle in loop optimization
• 23fc860: 8284294: Create an automated regression test for RFE 4138746
• b0af5e5: 8282936: Write a regression test for JDK-4615365
• 4c96224: 8288467: remove memory_operand assert for spilled instructions
• ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/42e3184f88b5039663207d25be4250bb6308be29...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @jmtd Pushed as commit 7aeba37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.