Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279076: C2: Bad AD file when matching SqrtF with UseSSE=0 #51

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Jan 4, 2022

Clean backport to improve x86_32.

Additional testing:

  • New regression test fails without the patch, passes with it
  • Linux x86_32 fastdebug tier1 passes with -XX:UseSSE=0 -XX:UseAVX=0

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279076: C2: Bad AD file when matching SqrtF with UseSSE=0

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/51/head:pull/51
$ git checkout pull/51

Update a local copy of the PR:
$ git checkout pull/51
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/51/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 51

View PR using the GUI difftool:
$ git pr show -t 51

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/51.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 4, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9d5ae2e38074c3df354aeab19ebbab7d4872165a 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0 Jan 4, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279076: C2: Bad AD file when matching SqrtF with UseSSE=0

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 4, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 4, 2022

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jan 28, 2022

Got the push approval.
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jan 28, 2022

Going to push as commit d34650a.
Since your change was applied there have been 136 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 28, 2022
@openjdk openjdk bot closed this Jan 28, 2022
@openjdk openjdk bot removed ready rfr labels Jan 28, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 28, 2022

@shipilev Pushed as commit d34650a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8279076-x86_32-sqrtf branch Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant