Skip to content

8269039: Disable SHA-1 Signed JARs#510

Closed
GoeLin wants to merge 2 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8269039
Closed

8269039: Disable SHA-1 Signed JARs#510
GoeLin wants to merge 2 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8269039

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 27, 2022

I backport this for parity with 17.0.5-oracle.

Almost clean except for the chunk of test/.../SecurityUtils.java that was already backported in
8278851: Correct signer logic for jars signed with multiple digestalgs


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/510/head:pull/510
$ git checkout pull/510

Update a local copy of the PR:
$ git checkout pull/510
$ git pull https://git.openjdk.org/jdk17u-dev pull/510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 510

View PR using the GUI difftool:
$ git pr show -t 510

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/510.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6d91a3eb7bd1e1403cfb67f7eb8ce06d7e08e7a7 8269039: Disable SHA-1 Signed JARs Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 27, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 27, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269039: Disable SHA-1 Signed JARs

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 774213f: 8256844: Make NMT late-initializable
  • 437c634: 8281181: Do not use CPU Shares to compute active processor count
  • 180f3d9: 8284944: assert(cnt++ < 40) failed: infinite cycle in loop optimization
  • 23fc860: 8284294: Create an automated regression test for RFE 4138746
  • b0af5e5: 8282936: Write a regression test for JDK-4615365
  • 4c96224: 8288467: remove memory_operand assert for spilled instructions
  • 201dad4: 8287396: LIR_Opr::vreg_number() and data() can return negative number
  • f044785: 8284680: sun.font.FontConfigManager.getFontConfig() leaks charset
  • 1675370: 8284956: Potential leak awtImageData/color_data when initializes X11GraphicsEnvironment

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 29, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jul 3, 2022

After adding the binary files the Pre-submit tests are green

@GoeLin
Copy link
Member Author

GoeLin commented Jul 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2022

Going to push as commit 1305516.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 7aeba37: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
  • a6c02bd: 8288360: CI: ciInstanceKlass::implementor() is not consistent for well-known classes
  • d3354af: 8287432: C2: assert(tn->in(0) != __null) failed: must have live top node
  • f73037d: 8286625: C2 fails with assert(!n->is_Store() && !n->is_LoadStore()) failed: no node with a side effect
  • 7f40f16: 8278067: Make HttpURLConnection default keep alive timeout configurable
  • 774213f: 8256844: Make NMT late-initializable
  • 437c634: 8281181: Do not use CPU Shares to compute active processor count
  • 180f3d9: 8284944: assert(cnt++ < 40) failed: infinite cycle in loop optimization
  • 23fc860: 8284294: Create an automated regression test for RFE 4138746
  • b0af5e5: 8282936: Write a regression test for JDK-4615365
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/0ea78e56d86badb2e0cf831b65059fe3b1c0ad1d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2022
@openjdk openjdk bot closed this Jul 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2022
@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@GoeLin Pushed as commit 1305516.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8269039 branch July 5, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants