Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281181: Do not use CPU Shares to compute active processor count #517

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jun 29, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8281181: Do not use CPU Shares to compute active processor count

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/517/head:pull/517
$ git checkout pull/517

Update a local copy of the PR:
$ git checkout pull/517
$ git pull https://git.openjdk.org/jdk17u-dev pull/517/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 517

View PR using the GUI difftool:
$ git pr show -t 517

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/517.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 29, 2022

⚠️ @MBaesken could not find any commit with hash a5411119c383225e9be27311c6cb7fe5d1700b68. Please update the title with the hash for an existing commit.

@openjdk openjdk bot changed the title Backport a5411119c383225e9be27311c6cb7fe5d1700b68 8281181: Do not use CPU Shares to compute active processor count Jun 29, 2022
@openjdk
Copy link

openjdk bot commented Jun 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281181: Do not use CPU Shares to compute active processor count

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review and removed ready Pull request is ready to be integrated labels Jun 29, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 29, 2022

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 29, 2022
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MBaesken
Copy link
Member Author

MBaesken commented Jul 1, 2022

Hi Severin, thanks for the review.

@MBaesken
Copy link
Member Author

MBaesken commented Jul 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 1, 2022

Going to push as commit 437c634.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 180f3d9: 8284944: assert(cnt++ < 40) failed: infinite cycle in loop optimization
  • 23fc860: 8284294: Create an automated regression test for RFE 4138746
  • b0af5e5: 8282936: Write a regression test for JDK-4615365
  • 4c96224: 8288467: remove memory_operand assert for spilled instructions
  • 201dad4: 8287396: LIR_Opr::vreg_number() and data() can return negative number

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 1, 2022
@openjdk openjdk bot closed this Jul 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 1, 2022
@openjdk
Copy link

openjdk bot commented Jul 1, 2022

@MBaesken Pushed as commit 437c634.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants